This repository was archived by the owner on Sep 5, 2024. It is now read-only.
chore(ci): use ChromeHeadless and FirefoxHeadless #11455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Splaktar
force-pushed
the
refactorCI
branch
2 times, most recently
from
28dc1be to
c858ad1
Compare
Splaktar
changed the title
Splaktar
force-pushed
the
refactorCI
branch
3 times, most recently
from
6074d81 to
e30002f
Compare
Splaktar
changed the title
Splaktar
force-pushed
the
refactorCI
branch
2 times, most recently
from
e63d947 to
692798b
Compare
Splaktar
force-pushed
the
refactorCI
branch
from
692798b to
fbdff71
Compare
devversion
approved these changes
Sep 25, 2018
config/karma-travis.conf.js
Outdated
| @@ -0,0 +1,28 @@ | |||
| const baseKarma = require('./karma.conf.js'); | |||
| process.env.CHROME_BIN = require('puppeteer').executablePath(); | |||
There was a problem hiding this comment.
Why even use puppeteer if the chrome binaries are already installed through Travis? We should either remove pupeteer, or remove the chrome addon of Travis.
There was a problem hiding this comment.
Puppeteer was the recommendation of the karma-chrome-launcher for headless. I'll give it a shot w/o it. It would be nice if npm i didn't install the 82 MB Chrome bundle each time.
There was a problem hiding this comment.
I agree. We should probably just remove puppeteer because I assume Travis has some better caching for its addons.
There was a problem hiding this comment.
Removing Puppeteer did indeed work. Thanks for the feedback!
Splaktar
added
in progress
fix gulp errors with NodeJS 10 switch to NodeJS 10 improve NPM configuration via `npm ci` and caching "$HOME/.npm" fix keywords entry in package.json disable Saucelabs update readme, docs, deps to AngularJS 1.7.4 Fixes #11410
Splaktar
force-pushed
the
refactorCI
branch
from
fbdff71 to
c523ca7
Compare
Splaktar
changed the title
Splaktar
added
pr: merge ready
marosoft
pushed a commit
to marosoft/material
that referenced
this pull request
Nov 11, 2018
…11455) fix gulp errors with NodeJS 10 switch to NodeJS 10 improve NPM configuration via `npm ci` and caching "$HOME/.npm" fix keywords entry in package.json disable Saucelabs update readme, docs, deps to AngularJS 1.7.4 Fixes angular#11410
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
All of our tests run on Chrome for Windows only.
Issue Number:
Fixes #11410. Fixes #11468.
What is the new behavior?
npm ciand caching"$HOME/.npm"Does this PR introduce a breaking change?
Other information