This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(interimElement): don't track elements that fail compilation #11471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Splaktar
suggested changes
Oct 11, 2018
Splaktar
added
in progress
codymikol
force-pushed
the
fix-interim-nonsense
branch
2 times, most recently
from
078708c to
a27e312
Compare
|
@Splaktar I finally got around to adding a test for this. I verified that the test fails in master and passes in this branch. |
prevent interimElements from being tracked as showingInterimElements when they fail to be compiled Fixes: angular#11460
codymikol
force-pushed
the
fix-interim-nonsense
branch
from
a27e312 to
dea2ab9
Compare
|
@Splaktar any update on this? 🐔 |
Splaktar
added
pr: merge ready
|
Sorry for the delay on this, it looks good to go! Thank you |
Splaktar
approved these changes
Mar 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent interimElements from being tracked as showingInterimElements
when they fail to be compiled
Fixes: #11460
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If an interimElement fails to compile it will still be added as a "showingInterimElement"
Issue Number: #11460
What is the new behavior?
Now interimElements will only be tracked in the showingInterimElements list if they successfully compile.
Does this PR introduce a breaking change?
Other information
Unfortunately the showingInterimElements var is private to the InterimElementFactory and so it is not possible to write unit tests for this without adding additional functionality to the source. If the maintainers decide that is necessary I can definitely do so.