Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

We're based on AngularJS 1.7.4.

Issue Number:
N/A

What is the new behavior?

Pick up ng-class bug fix in AngularJS 1.7.5.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Note that this fix in AngularJS 1.7.5 did not help with #10573 (or associated PR #11529).

to pick up ng-class bug fix
@Splaktar Splaktar added type: build pr: merge ready This PR is ready for a caretaker to review P4: minor Minor issues. May not be fixed without community contributions. pr: merge safe labels Nov 29, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Nov 29, 2018
@Splaktar Splaktar self-assigned this Nov 29, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Nov 29, 2018
@Splaktar Splaktar assigned jelbourn and unassigned Splaktar Nov 29, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit f90715c into master Nov 30, 2018
@Splaktar Splaktar deleted the updateToAngularJS-1.7.5 branch November 30, 2018 00:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants