Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(autocomplete): show dropdown on top only when there is room #11575

Merged
merged 1 commit into from
Jan 5, 2019
Merged

fix(autocomplete): show dropdown on top only when there is room #11575

merged 1 commit into from
Jan 5, 2019

Conversation

marosoft
Copy link
Contributor

@marosoft marosoft commented Jan 3, 2019 •
edited by Splaktar
Loading

Don't use the bounding rectangles of a document body to determine
the position of the dropdown.
Top and bottom values of the snap element are relative to the viewport,
which is enough to decide about the position of the dropdown.

Fixes #10859

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Dropdown is shown on top even if there is not enough space for it.
Issue Number: #10859

What is the new behavior?

A proper checks are made to determine if the dropdown should be shown on top or under.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@marosoft
fix(autocomplete): show dropdown on top only when there is room
a37f7cc 
Don't use the bounding rectangles of a document body to determine
the position of the dropdown.
Top and bottom values of the snap element are relative to the viewport,
which is enough to decide about the position of the dropdown.

Fixes angular#10859
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jan 3, 2019
@Splaktar Splaktar self-requested a review January 3, 2019 23:25
@Splaktar Splaktar self-assigned this Jan 3, 2019
Splaktar
Splaktar approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added pr: lgtm This PR has been approved by the reviewer P3: important Important issues that really should be fixed when possible. type: bug ux: integration pr: merge ready This PR is ready for a caretaker to review labels Jan 3, 2019
@Splaktar Splaktar added this to the 1.1.13 milestone Jan 3, 2019
@mmalerba mmalerba merged commit 8d965aa into angular:master Jan 5, 2019
@Splaktar Splaktar mentioned this pull request Jan 31, 2019
Merged
@Splaktar
Copy link
Contributor

We're currently investigating a regression that "might" be caused by this. PR #11626 reverts this change and is being tested to see if it solves the issue.

Splaktar added a commit that referenced this pull request Feb 1, 2019
@Splaktar
fix(autocomplete): show dropdown on top only when there is room
1656e0e 
This reverts commit 46e08e5

Related to #11626. Related to #11575. Related to #10859.
@Splaktar Splaktar mentioned this pull request Feb 1, 2019
Merged
3 tasks
@Splaktar Splaktar removed this from the 1.1.13 milestone Feb 1, 2019
Splaktar added a commit that referenced this pull request Feb 1, 2019
@Splaktar
fix(autocomplete): show dropdown on top only when there is room
0899e0e 
This reverts commit 46e08e5

Related to #11626. Related to #11575. Fixes #10859.
jelbourn pushed a commit that referenced this pull request Feb 8, 2019
@Splaktar @jelbourn
fix(autocomplete): show dropdown on top only when there is room (#11629)
38fb991 
This reverts commit 46e08e5

Related to #11626. Related to #11575. Fixes #10859.
Splaktar added a commit that referenced this pull request Mar 10, 2019
@Splaktar
fix(autocomplete): default dropdown to position bottom as default
9fd7429 
Fixes #11656. Relates to #10859, #11629, #11575.
Splaktar added a commit that referenced this pull request Mar 10, 2019
@Splaktar
fix(autocomplete): default dropdown to position bottom as default
ea3b8c1 
fix horizontal alignment edge cases
fix $mdUtil.getViewportTop to handle when body scrolling is disabled

Fixes #11656. Relates to #10859, #11629, #11575.
@Splaktar Splaktar mentioned this pull request Mar 10, 2019
Merged
3 tasks
Splaktar added a commit that referenced this pull request Mar 10, 2019
@Splaktar
fix(autocomplete): default dropdown to position bottom as default
cab0dcf 
fix horizontal alignment edge cases
fix $mdUtil.getViewportTop to handle when body scrolling is disabled

Fixes #11656. Relates to #10859, #11629, #11575.
Splaktar added a commit that referenced this pull request Mar 18, 2019
@Splaktar
fix(autocomplete): default dropdown to position bottom as default
e41ef82 
fix horizontal alignment edge cases
fix $mdUtil.getViewportTop to handle when body scrolling is disabled

Fixes #11656. Relates to #10859, #11629, #11575.
andrewseguin pushed a commit that referenced this pull request Mar 20, 2019
@Splaktar @andrewseguin
fix(autocomplete): default dropdown to position bottom as default (#1…
7674959 
…1670)

fix horizontal alignment edge cases
fix $mdUtil.getViewportTop to handle when body scrolling is disabled

Fixes #11656. Relates to #10859, #11629, #11575.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@Splaktar Splaktar Splaktar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Splaktar Splaktar

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug ux: integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

autocomplete: shows dropdown on top even when there is no room
4 participants
@marosoft @Splaktar @googlebot @mmalerba