Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Some styles like .layout-row > .flex-50 are duplicated in the final CSS output.

Issue Number:
Fixes #11609

What is the new behavior?

  • removed some duplicate layout > flex styles
  • reduced unminified CSS size by 5KB

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

reduce unminified CSS size by 5KB

Fixes #11609
@Splaktar Splaktar added type: bug ui: layout type: performance This issue is related to performance severity: regression This issue is related to a regression P2: required Issues that must be fixed. labels Jan 28, 2019
@Splaktar Splaktar added this to the 1.1.13 milestone Jan 28, 2019
@Splaktar Splaktar self-assigned this Jan 28, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jan 28, 2019
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Jan 28, 2019
@Splaktar Splaktar assigned mmalerba and unassigned josephperrott Jan 29, 2019
@mmalerba mmalerba merged commit 6515e6c into master Feb 1, 2019
@Splaktar Splaktar deleted the layout-reduceDuplicateStyles branch February 1, 2019 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug type: performance This issue is related to performance ui: layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

layout: duplicated flex styles
4 participants