This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(button): better support for ngDisabled and tabindex attributes #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBurleson
added
in progress
|
@marcysutton - can you review this for ARIA correctness. Thx. |
| * @returns {boolean} | ||
| */ | ||
| function isButton(attr) { | ||
| return !isAnchor(attr) && (attr.role == "button"); |
There was a problem hiding this comment.
@ThomasBurleson what is the use-case for this? We use native button elements that won't have a role attribute.
|
@ThomasBurleson what's the status of this PR? I just noticed disabled checkboxes have |
|
Will not merge. |
ThomasBurleson
removed
the
in progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1074.