Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

md-prevent-menu-close on md-menu-item with type checkbox or radio does not get forwarded to the generated button and thus it is not possible to disable closing the menu on toggling a checkbox or radio button.

Issue Number:
Fixes #11707

What is the new behavior?

md-prevent-menu-close on md-menu-item with type checkbox or radio gets forwarded to the generated button and thus it is possible to disable closing the menu on toggling a checkbox or radio button.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Apr 18, 2019
@Splaktar Splaktar added this to the 1.1.19 milestone Apr 18, 2019
@Splaktar Splaktar self-assigned this Apr 18, 2019
@Splaktar Splaktar added P4: minor Minor issues. May not be fixed without community contributions. type: enhancement pr: merge ready This PR is ready for a caretaker to review labels Apr 18, 2019
@Splaktar Splaktar assigned mmalerba and unassigned jelbourn Apr 19, 2019
@Splaktar Splaktar assigned andrewseguin and unassigned mmalerba May 9, 2019
@mmalerba mmalerba merged commit d577afd into master May 20, 2019
@Splaktar Splaktar deleted the menuBar-checkboxRespectPreventMenuClose branch May 21, 2019 01:05
@Splaktar Splaktar assigned mmalerba and unassigned andrewseguin May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

menu-bar: md-prevent-menu-close ineffective on checkbox items
5 participants