Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(autocomplete): options panel flickers on hover after clicking input #11757

Merged
merged 1 commit into from
Jul 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/autocomplete/js/autocompleteController.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function MdAutocompleteCtrl ($scope, $element, $mdUtil, $mdConstant, $mdTheming,
* close the options panel when a click outside said panel occurs. We use `documentElement`
* instead of body because, when scrolling is disabled, some browsers consider the body element
* to be completely off the screen and propagate events directly to the html element.
* @type {!angular.JQLite}
* @type {!Object} angular.JQLite
*/
ctrl.documentElement = angular.element(document.documentElement);

Expand Down Expand Up @@ -351,8 +351,8 @@ function MdAutocompleteCtrl ($scope, $element, $mdUtil, $mdConstant, $mdTheming,

/**
* Handles changes to the `hidden` property.
* @param hidden
* @param oldHidden
* @param {boolean} hidden
* @param {boolean} oldHidden
*/
function handleHiddenChange (hidden, oldHidden) {
if (!hidden && oldHidden) {
Expand Down
2 changes: 2 additions & 0 deletions src/components/autocomplete/js/autocompleteDirective.js
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,7 @@ function MdAutocomplete ($$mdSvgRegistry) {
ng-keydown="$mdAutocompleteCtrl.keydown($event)"\
ng-blur="$mdAutocompleteCtrl.blur($event)"\
ng-focus="$mdAutocompleteCtrl.focus($event)"\
ng-click="$event.stopPropagation()"\
aria-label="{{floatingLabel}}"\
aria-autocomplete="list"\
role="combobox"\
Expand Down Expand Up @@ -520,6 +521,7 @@ function MdAutocomplete ($$mdSvgRegistry) {
ng-keydown="$mdAutocompleteCtrl.keydown($event)"\
ng-blur="$mdAutocompleteCtrl.blur($event)"\
ng-focus="$mdAutocompleteCtrl.focus($event)"\
ng-click="$event.stopPropagation()"\
placeholder="{{placeholder}}"\
aria-label="{{placeholder}}"\
aria-autocomplete="list"\
Expand Down
4 changes: 2 additions & 2 deletions src/core/util/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,8 @@ function UtilFactory($document, $timeout, $compile, $rootScope, $$mdAnimate, $in

/**
* Disables scroll around the passed parent element.
* @param {!Element|!angular.JQLite} element Origin Element (not used)
* @param {!Element|!angular.JQLite} parent Element to disable scrolling within.
* @param {Element|angular.JQLite=} element Origin Element (not used)
* @param {Element|angular.JQLite=} parent Element to disable scrolling within.
* Defaults to body if none supplied.
* @param {Object=} options Object of options to modify functionality
* - disableScrollMask Boolean of whether or not to create a scroll mask element or
Expand Down