Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(progress-circular): correct rendering for diameter bigger than 60 #11896

Merged
merged 1 commit into from
May 11, 2020
Merged

fix(progress-circular): correct rendering for diameter bigger than 60 #11896

merged 1 commit into from
May 11, 2020

Conversation

marosoft
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

When the diameter of the spinner is bigger than 60px, the rendering is not correct due to the problem with the precision of floating point calculations.

Issue Number:
#10376

What is the new behavior?

Calculations were simplified to avoid the issue with the precision and to fix the rendering issue.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@marosoft
Copy link
Contributor Author

This a CodePen showing the fixed version.

@Splaktar Splaktar added this to the 1.1.23 milestone Apr 30, 2020
@Splaktar Splaktar self-assigned this Apr 30, 2020
Splaktar
Splaktar suggested changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I'd like to improve the readability and clarity of the code a little.

@Splaktar Splaktar added P4: minor Minor issues. May not be fixed without community contributions. browser: Chrome browser: IE This issue is specific to Internet Explorer hotlist: animations type: bug in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Apr 30, 2020
@marosoft marosoft force-pushed the wip/progress-circular-maths-fix-branch branch from 8c3fe87 to a9c348e Compare May 10, 2020 19:14
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label May 10, 2020
Splaktar
Splaktar approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review P3: important Important issues that really should be fixed when possible. and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs P4: minor Minor issues. May not be fixed without community contributions. labels May 11, 2020
@Splaktar Splaktar requested a review from mmalerba May 11, 2020 18:10
@mmalerba mmalerba merged commit 0cca317 into angular:master May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Splaktar Splaktar Splaktar approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@Splaktar Splaktar

Labels
browser: Chrome browser: IE This issue is specific to Internet Explorer cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ hotlist: animations P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Milestone
1.1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@marosoft @Splaktar @googlebot @mmalerba