Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(chips): cursor style on static chips #4114

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/chips/chips.scss
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ $contact-chip-name-width: rem(12) !default;
font-size: $chip-font-size;
padding: $chip-wrap-padding;
vertical-align: middle;
cursor: text;

&:not('.md-readonly') {
cursor: text;
}
.md-chip {
cursor: default;
border-radius: $chip-height / 2;
Expand Down
7 changes: 1 addition & 6 deletions src/components/chips/js/chipsDirective.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,7 @@
* <li>Colours for hover, press states (ripple?).</li>
* </ul>
*
* <ul>List Manipulation
* <li>delete item via DEL or backspace keys when selected</li>
* </ul>
*
* <ul>Validation
* <li>de-dupe values (or support duplicates, but fix the ng-repeat duplicate key issue)</li>
* <li>allow a validation callback</li>
* <li>hilighting style for invalid chips</li>
* </ul>
Expand Down Expand Up @@ -92,7 +87,7 @@
<md-chips-wrap\
ng-if="!$mdChipsCtrl.readonly || $mdChipsCtrl.items.length > 0"\
ng-keydown="$mdChipsCtrl.chipKeydown($event)"\
ng-class="{ \'md-focused\': $mdChipsCtrl.hasFocus() }"\
ng-class="{ \'md-focused\': $mdChipsCtrl.hasFocus(), \'md-readonly\': !$mdChipsCtrl.ngModelCtrl }"\
class="md-chips">\
<md-chip ng-repeat="$chip in $mdChipsCtrl.items"\
index="{{$index}}"\
Expand Down