This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(chips): remove style of chip if it blurs. #5795
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devversion please check CI |
After the user clicks everywhere else to deselect the chip, the selected chip variable will change in the controller but this needs to be applied to the scope Fixes angular#5662 fix(chip): Only apply selected chip after blur fix(chips): remove old jsdoc
devversion
force-pushed
the
fix/chips-blur-item
branch
from
890e580 to
8ecbfd5
Compare
ThomasBurleson
added
needs: review
|
This definitely needs a test, and some manual testing. I have run into multiple cases in the FAB Speed Dial where calling This is why I switched to |
topherfangio
added
needs: work
and removed
needs: review
|
I wan't to combine this PR with #5941, because there I already created a test section for the focus functionality. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the user clicks everywhere else to deselect the chip, the selected chip variable will change in the controller but this needs to be applied to the scope
Fixes #5662