Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(dialog): correctly disable keydown listener for escapeToClose #7222

Closed
wants to merge 1 commit into from
Closed

fix(dialog): correctly disable keydown listener for escapeToClose #7222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/dialog/dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,7 @@ function MdDialogProvider($$interimElementProvider) {
};

if (options.escapeToClose) {
var target = options.parent;
var parentTarget = options.parent;
var keyHandlerFn = function(ev) {
if (ev.keyCode === $mdConstant.KEY_CODE.ESCAPE) {
ev.stopPropagation();
Expand All @@ -787,13 +787,13 @@ function MdDialogProvider($$interimElementProvider) {

// Add keydown listeners
element.on('keydown', keyHandlerFn);
target.on('keydown', keyHandlerFn);
parentTarget.on('keydown', keyHandlerFn);

// Queue remove listeners function
removeListeners.push(function() {

element.off('keydown', keyHandlerFn);
target.off('keydown', keyHandlerFn);
parentTarget.off('keydown', keyHandlerFn);

});
}
Expand Down