This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): probably clear the autocomplete. #7354
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment we calling the `select(-1)` function, but that will cause problems, because it will stuck. There is no need of calling the `select(-1)` function, we should just clear the loading indicator on an synchronous query. On an async query, the loading indicator will be set by default to false on completion. This fixes the issue, which required two clicks on a list item after cleared the autocomplete through the button. Fixes angular#7180
|
LGTM |
devversion
added
pr: merge ready
ThomasBurleson
pushed a commit
that referenced
this pull request
Apr 1, 2016
At the moment we calling the `select(-1)` function, but that will cause problems, because it will stuck. There is no need of calling the `select(-1)` function, we should just clear the loading indicator on an synchronous query. On an async query, the loading indicator will be set by default to false on completion. This fixes the issue, which required two clicks on a list item after cleared the autocomplete through the button. Fixes #7180 Closes #7354
ThomasBurleson
pushed a commit
that referenced
this pull request
Apr 1, 2016
At the moment we calling the `select(-1)` function, but that will cause problems, because it will stuck. There is no need of calling the `select(-1)` function, we should just clear the loading indicator on an synchronous query. On an async query, the loading indicator will be set by default to false on completion. This fixes the issue, which required two clicks on a list item after cleared the autocomplete through the button. Fixes #7180 Closes #7354
gmoothart
pushed a commit
to gmoothart/material
that referenced
this pull request
Apr 5, 2016
At the moment we calling the `select(-1)` function, but that will cause problems, because it will stuck. There is no need of calling the `select(-1)` function, we should just clear the loading indicator on an synchronous query. On an async query, the loading indicator will be set by default to false on completion. This fixes the issue, which required two clicks on a list item after cleared the autocomplete through the button. Fixes angular#7180 Closes angular#7354
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
select(-1)function when clearing, but that will cause problems, because it will stuck with the matches.select(-1)function, we should just clear the loading indicator on an synchronous query.On an async query, the loading indicator will be set by default to false on completion.
This fixes the issue, which required two clicks on a list item after cleared the autocomplete through the button.
Fixes #7180