This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): fix incorrect height for progress-bar #7504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current indeterminate class wasn't privatized and that caused the progress bar to have a height of 5px, instead of 3px Fixes angular#7497
|
DevVersion, i suspect same error happened with select. Loading on select is almost two times larger than before. |
|
I've replied to your issue @gpopovic, this PR isn't related to it. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current indeterminate class wasn't privatized and that caused the progress bar to have a height of 5px, instead of 3px
@topherfangio Seems like you forgot to privatize the indeterminate class here. Can you review this PR?
Fixes #7497