This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(checkbox): pointer events disable ripple events too #7541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not disable the ripple events by using `pointer-events: none`. IE11 always focuses the div, instead of the `md-checkbox`, and that's causing issues with ngModel etc. I good trick is, to redirect the focus, instead of preventing the whole focus / pointer events. This won't interfere with the ripple, but it will fix the IE11 issue. https://connect.microsoft.com/IE/feedback/details/1028411/ Fixes angular#7538
devversion
force-pushed
the
fix/checkbox-ripple-events
branch
from
01e09a4 to
487a50e
Compare
|
LGTM |
EladBezalel
added
pr: merge ready
|
I am confused can we not use tabindex= 0 or -1 to solve the issue without programmatically redirecting focus? |
ThomasBurleson
added
the
needs: team discussion
|
@ThomasBurleson That won't work, because that's the actual IE11 bug. |
|
@devversion - That is what I needed to know. Thx. |
ThomasBurleson
removed
the
needs: team discussion
ThomasBurleson
pushed a commit
that referenced
this pull request
Mar 16, 2016
We should not disable the ripple events by using `pointer-events: none`. IE11 always focuses the div, instead of the `md-checkbox`, and that's causing issues with ngModel etc. * redirect the focus, instead of preventing the whole focus / pointer events. * @see https://connect.microsoft.com/IE/feedback/details/1028411/ Fixes #7538. Closes #7541.
ThomasBurleson
pushed a commit
that referenced
this pull request
Apr 1, 2016
We should not disable the ripple events by using `pointer-events: none`. IE11 always focuses the div, instead of the `md-checkbox`, and that's causing issues with ngModel etc. * redirect the focus, instead of preventing the whole focus / pointer events. * @see https://connect.microsoft.com/IE/feedback/details/1028411/ Fixes #7538. Closes #7541.
ThomasBurleson
pushed a commit
that referenced
this pull request
Apr 1, 2016
We should not disable the ripple events by using `pointer-events: none`. IE11 always focuses the div, instead of the `md-checkbox`, and that's causing issues with ngModel etc. * redirect the focus, instead of preventing the whole focus / pointer events. * @see https://connect.microsoft.com/IE/feedback/details/1028411/ Fixes #7538. Closes #7541.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not disable the ripple events by using
pointer-events: none.IE11 always focuses the div, instead of the
md-checkbox, and that's causing issues with ngModel etc.A good trick is, to redirect the focus, instead of preventing the whole focus / pointer events.
This won't interfere with the ripple, but it will fix the IE11 issue.
https://connect.microsoft.com/IE/feedback/details/1028411/
cc @ThomasBurleson
Fixes #7538