Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

janeisklar
Copy link

Compare to pull request #7056 for a similar issue with md-menu
Changes:

  • <md-chips>, <md-chip-template>, etc. can now also be used as <data-md-chips>, <data-md-chip-template>
  • added a basic usage demo that features those <data-*> tags
  • made the corresponding tests parametrized so that they are executed both with and without the data-prefix

Background:
'data-'-prefixing is f.e. done by angular-htmlify and allows for the W3C validation of angular templates

Changes:
* <md-chips>, <md-chip-template>, etc. can now also be used as <data-md-chips>, <data-md-chip-template>
* added a basic usage demo that features those <data-*> tags
* made the corresponding tests parametric so that they are executed both with and without the prefix

'data-'-prefixing is f.e. done by angular-htmlify and allows for the W3C validation of angular templates
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@janeisklar
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@@ -1,4 +1,4 @@
md-chips.md-THEME_NAME-theme {
md-chips.md-THEME_NAME-theme, data-md-chips.md-THEME_NAME-theme {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that. This would require a selector for x- as well.

We should either apply a class, to identify the chips directive.

@ThomasBurleson
Copy link
Contributor

A generic solution to data- prefixing is in progress. Will not merge this PR.

@janeisklar
Copy link
Author

Is there an issue that you could reference allowing us to track the progress of the mentioned generic solution?

@devversion
Copy link
Member

@janeisklar Yes it is.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants