This repository was archived by the owner on Sep 5, 2024. It is now read-only.
feat(theming): register custom theme styles #8641
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| inject(function($MD_THEME_CSS) { expect($MD_THEME_CSS).toBe('/**/'); }); | ||
|
|
||
| // Find the string '/**//*test*/' in the head tag. | ||
| expect(document.head.innerHTML).toMatch(/\/\*\*\/\/\*test\*\//); |
There was a problem hiding this comment.
This might be a little more readable with indexOf/toContain.
There was a problem hiding this comment.
Agreed, this was directly ported from #7864
* Add a public method, which allows developers to register their own theme styles for the app theming * Adds descriptions and examples to the service documentation. Credits to @Emeegeemee for implementing the `registerStyles` functionality. Closes angular#7708. Closes angular#7864.
devversion
force-pushed
the
submit/pr-7864
branch
from
d7bf4c3 to
7b16e66
Compare
ThomasBurleson
added
the
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credits to @Emeegeemee for implementing the
registerStylesfunctionality.Closes #7708. Closes #7864.