This repository was archived by the owner on Sep 5, 2024. It is now read-only.
feat(panel): add RTL support #8990
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EladBezalel
force-pushed
the
fix/panel-rtl-support
branch
from
8fd4e8f to
62e67b6
Compare
| if (this._$mdUtil.bidi() === 'rtl') { | ||
| position.x = reverseXPosition(position.x); | ||
| } | ||
|
|
||
| switch (position.x) { |
There was a problem hiding this comment.
I recommend this:
function reversePosition (position) {
var start = 'start', end = 'end';
return position.includes(start) ? position.replace( start, end ) : position.replace( end, start );
}
function bidi(position) {
return (this._$mdUtil.bidi() === 'rtl') ? reversePosition(position) : position;
}
switch ( bidi(position.x) ) {
...
}
|
So this definitely fixes bidi for relative positioning, but not for absolute. If I want a popup on the left side of the screen, I'd still want it to be first in reading order in RTL languages. What's the plan for fixing absolution positioning? |
|
@EladBezalel - ping |
EladBezalel
added
in progress
EladBezalel
force-pushed
the
fix/panel-rtl-support
branch
from
62e67b6 to
a630487
Compare
|
@ErinCoughlan please re-review, |
EladBezalel
force-pushed
the
fix/panel-rtl-support
branch
from
a630487 to
6fdccf7
Compare
EladBezalel
added
needs: review
| /** @private @const */ | ||
| this._$window = $window; | ||
| function MdPanelPosition($injector) { | ||
| /** @private @const {!angular.$window}*/ |
There was a problem hiding this comment.
Nit: space after type before */
EladBezalel
force-pushed
the
fix/panel-rtl-support
branch
2 times, most recently
from
484a585 to
5c96f9e
Compare
| this._top = this._bottom = ''; | ||
| } | ||
| else { | ||
| throw new Error('Position must be one of ' + Object.keys(MdPanelPosition.absPosition).join().toLowerCase() + '.'); |
|
LGTM, Approval 😄 |
- If the application is in RTL mode we swap the `OFFSET` and `ALIGN` - `START` and `END` positions, it tricks the function to switch it origin point and calculate the panel position right. - Added `start` and `end` APIs to support bidi fixes #8974
EladBezalel
force-pushed
the
fix/panel-rtl-support
branch
from
5c96f9e to
227b01f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OFFSETandALIGN-STARTandENDpositions, it tricks the function to switch it origin point and calculate the panel position right.fixes #8974