This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(input): Fix message animation not running. #9044
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topherfangio
added
in progress
topherfangio
force-pushed
the
fix-inputs-messages-8864
branch
3 times, most recently
from
359aee4 to
1279670
Compare
|
@topherfangio - can rebase and verify this is working and ready ? |
topherfangio
force-pushed
the
fix-inputs-messages-8864
branch
from
1279670 to
7434da8
Compare
topherfangio
added
needs: review
|
@ThomasBurleson This is ready for review; particularly seeing whether to use Protractor or Karma. Once we decide, we can delete the other ones if we want. Also note that this switches to PhantomJS2. This was required to get the Karma tests passing. |
topherfangio
force-pushed
the
fix-inputs-messages-8864
branch
from
7434da8 to
2849026
Compare
If an input switched from one error state directly to another error state, the second error animation would fail. Update input animation code to handle this situation and be drastically cleaner and fix a bug in `getMessagesElement()` method which disallowed multiple `ng-messages` elements. Fixes angular#8635. Fixes angular#8864. Fixes angular#8973.
topherfangio
force-pushed
the
fix-inputs-messages-8864
branch
from
2849026 to
90f67c7
Compare
|
just curious whether this will be a candidate for the 1.1.0 release? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an input switched from one error state directly to another error
state, the second error animation would fail.
Update input animation code to handle this situation and be
drastically cleaner and fix a bug in
getMessagesElement()method which disallowed multiple
ng-messageselements.Fixes #8635. Fixes #8864. Fixes #8973.