This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(datepicker): mark the input as invalid on submit, add missing import #9050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,7 +53,7 @@ | |||
| * </hljs> | |||
| * | |||
| */ | |||
| function datePickerDirective($$mdSvgRegistry) { | |||
| function datePickerDirective($$mdSvgRegistry, $mdUtil) { | |||
There was a problem hiding this comment.
#9049 is for ngAria, but yeah it makes sense to merge these two.
* Fixes invalid datepickers not being highlighted when their parent form is submitted. * Fixes $mdAria not being imported and causing a JS error occasionally. Fixes angular#8411.
crisbeto
force-pushed
the
8411/datepicker-highlight-on-submit
branch
from
f54ddd0 to
8f63c06
Compare
crisbeto
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8411.