Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(chips): fallback to detect cursor position #9116

Closed

Conversation

devversion
Copy link
Member

@devversion devversion commented Jul 22, 2016

  • In some cases the browser is not able to use the selectionStart propety to detect the cursor position

Figure out whether the current input for the chips buffer is valid for using
the selectionStart / end property to retrieve the cursor position.
Some browsers do not allow the use of those attributes, on different input types.

  • Also simplified the tests, by reducing the repetitions

Fixes #9097.

@devversion devversion added the needs: review This PR is waiting on review from the team label Jul 22, 2016
* In some cases the browser is not able to use the  `selectionStart` propety to detect the cursor position

>  Figure out whether the current input for the chips buffer is valid for using
> the selectionStart / end property to retrieve the cursor position.
> Some browsers do not allow the use of those attributes, on different input types.

Fixes angular#9097.
@devversion devversion force-pushed the fix/chips-unsupported-cursor-pos branch from ea9b7e5 to 945b8ea Compare July 23, 2016 09:03
@ThomasBurleson ThomasBurleson added pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Jul 25, 2016
@devversion devversion deleted the fix/chips-unsupported-cursor-pos branch September 15, 2016 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants