feat(browser-color): enable browser header coloring #9192
Conversation
| * @param {Object} options Options object for the browser color | ||
| * @returns {Function} remove function of the browser color | ||
| */ | ||
| var enableBrowserColor = function (options){ |
There was a problem hiding this comment.
Nit: Missing space here at brace
|
@ThomasBurleson That looks very good. LGTM. |
EladBezalel
force-pushed
the
feat/browser-color
branch
from
3207057 to
36f2260
Compare
|
@EladBezalel tests? |
EladBezalel
force-pushed
the
feat/browser-color
branch
from
36f2260 to
68c8b92
Compare
|
@ErinCoughlan done |
| * | ||
| * @description | ||
| * | ||
| * A provider and a service that simplifies meta tags access |
There was a problem hiding this comment.
Might make a note that certain <meta> tags (such as charset, http-equiv="Content-Type", and I think name="viewport") cannot be added dynamically because the browser will have already decided how to render (and probably rendered) the page by the time they get added.
I could not find a complete list of the ones that were editable, but this caught me the other day so it's probably not very obvious to most devs :-)
|
Left a few comments for consideration, but looks pretty great to me! |
| @@ -242,6 +270,53 @@ function ThemingProvider($mdColorPalette) { | |||
|
|
|||
| // Default theme defined in core.js | |||
|
|
|||
| /** | |||
| * | |||
EladBezalel
force-pushed
the
feat/browser-color
branch
3 times, most recently
from
8583337 to
7c236da
Compare
| expect($$mdMeta.getMeta(name)).toBe(content); | ||
| }); | ||
| }); | ||
| }); |
|
How do you feel about a directive based around a class or attribute, that when added to an element, takes it's background color or For example This is what I use to achieve a similar toolbar affect in Angular Material as done in https://inbox.google.com/ |
|
@clshortfuse I think providing the service is enough. Developers should be able to figure out what color/hue the toolbar will use and match that relatively easily. |
EladBezalel
force-pushed
the
feat/browser-color
branch
from
7c236da to
df3ea14
Compare
|
@ThomasBurleson LGTM 👍 |
EladBezalel
added
pr: merge ready
- provides an easy way to set and change the browser color according the material design spec colors and the defined themes fixes #8062
EladBezalel
force-pushed
the
feat/browser-color
branch
from
df3ea14 to
db84790
Compare
fixes #8062