This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): Allow 0 as default value. #9237
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change introduced a bug which no longer allowed
0
as a validng-value
.Fix by surrounding associated
if
code withangular.isDefined(...)
to ensure0
is treated as a valid value.Fixes #9232.
Note: It looks like lots of changes to the
.spec.js
file because I moved some of the tests to a more relevant location. In reality, I only added 1 test and moved the others. See my line comment for the actual change.