Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

topherfangio
Copy link
Contributor

A recent change introduced a bug which no longer allowed 0 as a valid ng-value.

Fix by surrounding associated if code with angular.isDefined(...) to ensure 0 is treated as a valid value.

Fixes #9232.

Note: It looks like lots of changes to the .spec.js file because I moved some of the tests to a more relevant location. In reality, I only added 1 test and moved the others. See my line comment for the actual change.

A recent change introduced a bug which no longer allowed `0` as a
valid `ng-value`.

Fix by surrounding associated `if` code with `angular.isDefined(...)`
to ensure `0` is treated as a valid value.

Fixes angular#9232.
@topherfangio topherfangio added the P0: critical Critical issues that must be addressed immediately. label Aug 4, 2016
@topherfangio topherfangio added this to the 1.1.0 milestone Aug 4, 2016
$rootScope.$digest();
expect(label.textContent).toBe('4');
}));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below (like 268) is the added test; everything else already existed; just moved it around a bit for clarity.

@topherfangio
Copy link
Contributor Author

@ThomasBurleson I have marked this as 1.1.0 because I'm pretty sure we broke it in the last release and it seems like a significant enough break that we want to get it fixed before the final push.

@devversion
Copy link
Member

@ThomasBurleson - That looks perfect. I also think it would be good to get that into 1.1.0.

@topherfangio topherfangio added the needs: review This PR is waiting on review from the team label Aug 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: review This PR is waiting on review from the team P0: critical Critical issues that must be addressed immediately.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants