Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Aug 5, 2016

No description provided.

@jelbourn
Copy link
Member Author

jelbourn commented Aug 5, 2016

@topherfangio or @EladBezalel take a look?

@EladBezalel
Copy link
Member

Referring your message:

The changes for mdIcon with $sce aren't working out due to security change that was made with angular 1.5
this change would mean that for people who want to load svg icons, they have to do one of the following:

  • Request icons from the same-origin
  • Pre-load icons into the $templateCache
  • Add the origins for the icon requests to the $sce whitelist

So this is actually a breaking change, can't we polyfill the 1.5 fix?

@jelbourn
Copy link
Member Author

jelbourn commented Aug 8, 2016

@EladBezalel this is a breaking change from previous versions. The allowed sources for SVG icons are now more strict, which enforces a stronger security model.

@EladBezalel
Copy link
Member

LGTM

@topherfangio
Copy link
Contributor

LGTM 👍

@jelbourn jelbourn merged commit 2ddeb91 into angular:master Aug 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants