This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): properly show dropdown on focus when minlength is met #9291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 11, 2016
| function isSearchable() { | ||
| if (ctrl.loading && !hasMatches()) return false; // No query when query is in progress. | ||
| else if (hasSelection()) return false; // No query if there is already a selection | ||
| else if (!hasFocus) return false; // No query if the input does not have focus |
There was a problem hiding this comment.
Quick note: I don't think the else if is necessary here since you're doing a return. I'm really not sure why I had that in my shouldHide() code...
|
Code-wise it looks pretty good. I'll need to do some manual testing to make sure it works as expected. |
topherfangio
added
the
needs: manual testing
This was referenced Aug 17, 2016
…met. Currently the `md-autocomplete` shows its dropdown only by changing the `searchText` from `null` to an empty string. > This triggered a searchText change, which resulted in triggering a query. This approach doesn't seem to be very elegant. > The autocomplete should manually trigger a query and possibly open the dropdown if matches are available. Fixes angular#9283. Closes angular#9288. Closes angular#9289.
devversion
force-pushed
the
fix/autocomplete-focus-min-length
branch
from
ac49151 to
fc4fc91
Compare
|
@ThomasBurleson LGTM 👍 |
topherfangio
removed
the
needs: manual testing
ThomasBurleson
added
pr: merge ready
| // Wait for the input to move horizontally, because the chip was removed. | ||
| // This can lead to an incorrect dropdown position. | ||
| this.autocompleteCtrl.hidden = true; | ||
| this.$mdUtil.nextTick(this.onFocus.bind(this)); |
There was a problem hiding this comment.
@devversion I updated to 1.1.1 and this breaks, because this.$mdUtil is undefined. It is never assigned in the constructor.
There was a problem hiding this comment.
Known issue - see #9528
Frank3K
pushed a commit
to Frank3K/material
that referenced
this pull request
Sep 11, 2016
…met. (angular#9291) Currently the `md-autocomplete` shows its dropdown only by changing the `searchText` from `null` to an empty string. > This triggered a searchText change, which resulted in triggering a query. This approach doesn't seem to be very elegant. > The autocomplete should manually trigger a query and possibly open the dropdown if matches are available. Fixes angular#9283. Closes angular#9288. Closes angular#9289.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
md-autocompleteshows its dropdown only by changing thesearchTextfromnullto an empty string.This approach doesn't seem to be very elegant.
@topherfangio Can you take a look (especially on the chips with autocomplete behavior)
@ThomasBurleson I consider this as too risky for 1.1.0 (specifically the behavior with the chips)
Fixes #9283. Closes #9288. Closes #9289.