feat(compiler): pass $element to controller instantiation #9516
Conversation
* Pass the `$element` local to the instantiated controller, as same as a normal Angular 1.x DDO. Closes angular#9507.
| var invokeCtrl = $controller(controller, locals, true, controllerAs); | ||
|
|
||
| var ctrlLocals = angular.extend(locals, { | ||
| $element: element |
There was a problem hiding this comment.
What about the $attr?
There was a problem hiding this comment.
That's unfortunately not possible, because the Attributes constructor is internal-only.
https://github.com/angular/angular.js/blob/master/src/ng/compile.js#L1508
Also doesn't make any sense to have the $attrs here, because the template is always static, and the user can't specify attributes dynamically.
There was a problem hiding this comment.
$attrs might make sense once we start supporting content elements.
There was a problem hiding this comment.
It's still not possible. Though contentElement's are still not dynamic, those are just to avoid compilation each time and are pre-rendered elements.
Once I created this functionality, the intention was just to support
pre-renderedDOM elements.
|
@ThomasBurleson @crisbeto Any other feedback to address ? |
|
Nope, it LGTM. |
ThomasBurleson
added
needs: presubmit
and removed
needs: review
kara
added
pr: merge ready
* Pass the `$element` local to the instantiated controller, as same as a normal Angular 1.x DDO. Closes angular#9507.
$elementlocal to the instantiated controller, as same as a normal Angular 1.x DDO.Closes #9507.