This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): two specs leak the scroll mask element #9568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devversion
commented
Sep 10, 2016
devversion
commented
- The scroll mask was not removed by two specs of the autocomplete and could cause unexpected issues in other suites, when setting focus on those.
When running the panel tests separately from all the others, the one about disabling scrolling was failing. This wasn't happening when running it together with all the other components, because some other component (not sure exactly which one, but it seemed like either dialog or autocomplete) wasn't cleaning up the DOM properly and was leaving a scroll mask lying around. This change removes the DOM lookup for the scroll mask, because it looks like it got disabled in PR angular#8901, however the test didn't get updated.
* The scroll mask was not removed by two specs of the autocomplete and could cause unexpected issues in other suites, when setting focus on those.
|
@ThomasBurleson Please do merge this after #9566, because this PR is based on @crisbeto's |
devversion
added
the
Blocked
devversion
changed the title
ThomasBurleson
added
pr: merge ready
Frank3K
pushed a commit
to Frank3K/material
that referenced
this pull request
Sep 11, 2016
* chore(panel): fix failing unit test When running the panel tests separately from all the others, the one about disabling scrolling was failing. This wasn't happening when running it together with all the other components, because some other component (not sure exactly which one, but it seemed like either dialog or autocomplete) wasn't cleaning up the DOM properly and was leaving a scroll mask lying around. This change removes the DOM lookup for the scroll mask, because it looks like it got disabled in PR angular#8901, however the test didn't get updated. * fix(autocomplete): two specs leak the scroll mask element * The scroll mask was not removed by two specs of the autocomplete and could cause unexpected issues in other suites, when setting focus on those.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.