This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(docs, dialog, interim, panel): compatibility with latest angular snapshot #9787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…snapshot * Fixes the docs site not working against the latest snapshot. * Fixes the `dialog` throwing an error about `ngSanitize` not being present and then compiling the contents anyway. * Makes the `interimElement` compatible both with the latest changes to promises from Angular PR #15213 and the current promise handling in Angular <= 1.5. * Reintroduces the panel changes from angular#9688 which were overwritten accidentally. * Fixes an error that was being swallowed during unit tests, but was still showing up in the `$exceptionHandler`.
|
LGTM for the |
devversion
approved these changes
Oct 8, 2016
| // the rejection and only log it if it's an error. | ||
| interimElement.deferred.promise.catch(function(fault) { | ||
| if (fault instanceof Error) { | ||
| $exceptionHandler(fault); |
| try { | ||
| notifyShowing(options.scope, element, options, controller); | ||
| } catch (e) { | ||
| return $q.reject(e); |
ThomasBurleson
added
needs: presubmit
and removed
needs: review
ThomasBurleson
added
the
P0: critical
kara
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dialogthrowing an error aboutngSanitizenot being present and then compiling the contents anyway.interimElementcompatible both with the latest changes to promises from Angular PR #15213 and the current promise handling in Angular <= 1.5.$exceptionHandler.