This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(sidenav): correct animation from closed to locked open #9833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test with http://codepen.io/shortfuse/pen/GjGzbv (localhost) The repeated CSS rules are intentional for commenting. Since they are sequentially in order, they will get squashed during minification. |
|
The open animation seems to be broken |
EladBezalel
suggested changes
Oct 17, 2016
| @@ -18,55 +18,76 @@ md-sidenav { | |||
| list-style: none; | |||
| } | |||
|
|
|||
| // unlocked|open (default) | |||
There was a problem hiding this comment.
I can't understand what this notation means..
clshortfuse
force-pushed
the
sideNav-fixLockedOpenAnimation
branch
3 times, most recently
from
4f13abb to
df7592d
Compare
EladBezalel
approved these changes
Oct 17, 2016
sidenav was missing CSS a pre-animation state when transitioning from closed to locked open * Add CSS for missing pre-animation state * Add comments to clarify animation logic Fixes angular#9425
clshortfuse
force-pushed
the
sideNav-fixLockedOpenAnimation
branch
from
df7592d to
75a6603
Compare
EladBezalel
added
needs: presubmit
and removed
needs: review
topherfangio
approved these changes
Oct 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sidenav was missing CSS a pre-animation state when transitioning
from closed to locked open
Fixes #9425