This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(tabs): improve tab button focus styling logic #9916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tab buttons did not receive focus style unless the user performed certain keypress events while navigating. This logic did not account for tabbing into the component * Set variable when tab button is focused * Use mdInteraction to detect keyboard interaction This new logic is similar to that of mdCheckbox Fixes angular#9039
clshortfuse
added
ui: focus
needs: review
devversion
approved these changes
Oct 25, 2016
ThomasBurleson
added
needs: presubmit
and removed
needs: review
kara
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tab buttons did not receive focus style unless the user performed
certain keypress events while navigating. This logic did not account
for tabbing into the component
This new logic is similar to that of mdCheckbox
Fixes #9039