feat(autocomplete): pass md-input-max/min-length to the input with no…

[theLufenk]

…n-floating label

Adds the md-input-minlength and md-input-maxlength attributes as ng-minlength and ng-maxlength to the input element of the autocomplete directive when a floating label is not used.
A use case : It would help in validating the input when the value of Search Text is being used if no matches are found.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[theLufenk]

I believed it would be taken up with #4492 . However it wasn't.
As of now, there is no way to add length validation to the text input element.

The value of Search Text is exposed , hence it can be used in a scenario when we want the autocomplete to serve as both a suggestion list as well as text input .

[googlebot]

CLAs look good, thanks!

[googlebot]

CLAs look good, thanks!

[devversion]

Thanks for the pull request - The reason why the ng-min/max-length attributes are not supported a normal autocomplete is that we don't support ng-messages for a normal autocomplete.

My question here is, how will you validate the "underlaying" input?

[theLufenk]

The property is exposed as [FORM_NAME].[MD_INPUT_NAME].$error.maxlength nonetheless.

[devversion]

@theLufenk Ah I see. From this perspective it makes sense to support those validator attributes for the normal autocomplete.

Can you please some tests for those two attributes?

[theLufenk]

Added tests. The spec was missing tests for md-input-minlength. Added them too.
I suppose checking for presence of ng-maxlength/ng-minlength attribute in the render input element and $valid state of container forms would be sufficient ?

[devversion]

@theLufenk Perfect! I think the tests which are only checking for the attribute on the input are not necessary when having the tests for the $valid state.

If you have time it would be great to have them removed (those are unnecessary and bloating the specs)

[theLufenk]

Done and rebased.

[devversion]

LGTM. Thanks