demonstrate runtime error for @nebular/theme

[rayman1104]

Repro for #529

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[rayman1104]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[petebacondarwin]

The error is that the injector is not able to create NbScrollStrategyOptions. This is because it is not finding the injectable definition for this type.

I can see that ngcc is doing the right thing:

    NbScrollStrategyOptions.ngInjectableDef = ɵɵdefineInjectable({ factory: function NbScrollStrategyOptions_Factory() { return new NbScrollStrategyOptions(ɵɵinject(NbLayoutScrollService), ɵɵinject(ScrollDispatcher$1), ɵɵinject(NbViewportRulerAdapter), ɵɵinject(NgZone), ɵɵinject(NB_DOCUMENT)); }, token: NbScrollStrategyOptions, providedIn: "root" });

The problem is that getInjectableDef() is not doing the right thing... See https://github.com/angular/angular/blob/86104b82b8af87efab46db50962e6b16f3724672/packages/core/src/di/interface/defs.ts#L192-L202

The code is effectively:

export function getInjectableDef<T>(type: any): ɵɵInjectableDef<T>|null {
  const def = (type.ɵprov || type.ngInjectableDef) as ɵɵInjectableDef<T>;
  return def && def.token === type ? def : null;
}

Checking the def.token === type is to prevent bringing in the definition from the type's super class.

But in this case it is wrong because, while ɵprov is inherited and so should not be used ngInjectableDef is available and not inherited. So that one should be used.

[petebacondarwin]

Actually I just realised that ngcc should be using the "new" name (i.e. ɵprov replaced ngInjectableDef). So perhaps there are two fixes...

1. make core more resilient to a derived class using the old name when a super class uses the new name
2. fix ngcc to output the new name rather than the old name

[petebacondarwin]

Actually!!

It turns out that this ngInjectableDef was already in the library published to npm, so ngcc had no hand in defining it. I checked and ngcc will always add the correct ɵprov property. So it is only legacy libraries that have this problem.

Therefore the fix really is only 1) from above.