Skip to content
This repository was archived by the owner on Mar 20, 2024. It is now read-only.

Conversation

josephliccini
Copy link
Contributor

In this change, the activeNode in Preboot is set for any focus event, not
just those in <input> or <textarea>.
This helps those who use screenreaders maintain focus during
the swap between server and client views.

Closes #105

  • Please check if the PR fulfills these requirements
  • What modules are related to this pull-request
  • server side
  • client side
  • inline
  • build process
  • docs
  • tests
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    remove unused proxy imports from some test files
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Setting Focus is not applying to screenreader elements, only TextArea and Input elements #105

  • What is the new behavior (if this is a feature change)?
    activeNode is set for focus on any element, not just input and textarea

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

In this change, the activeNode in Preboot is set for any focus event, not
just those in `<input>` or `<textarea>`.
This helps those who use screenreaders maintain focus during
the swap between server and client views.

Closes angular#105
@josephliccini josephliccini force-pushed the josephliccini/preboot-accessibility branch from 4319bd4 to ff756a7 Compare July 18, 2019 23:36
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

@CaerusKaru CaerusKaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaerusKaru CaerusKaru merged commit 9090fa5 into angular:master Jul 19, 2019
@CaerusKaru
Copy link
Member

I can't cut a release this week, but if I don't cut one by Tuesday next week please ping this issue. And thank you for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting Focus is not applying to screenreader elements, only TextArea and Input elements
3 participants