Skip to content
This repository was archived by the owner on Mar 20, 2024. It is now read-only.

Conversation

mgol
Copy link
Member

@mgol mgol commented Feb 14, 2018

Without this change npm test fires up Karma but does nothing further with it.

  • Please check if the PR fulfills these requirements
  • What modules are related to this pull-request
  • server side
  • client side
  • inline
  • build process
  • docs
  • tests
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    remove unused proxy imports from some test files

A test setup fix.

  • What is the current behavior? (You can also link to an open issue here)

npm test fires up Karma but does nothing further with it.

  • What is the new behavior (if this is a feature change)?

npm test fires up Karma & re-runs unit tests on every file modification.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No.

  • Other information:

package.json Outdated
@@ -12,7 +12,7 @@
"pretest": "npm run build-test",
"test": "concurrently \"npm run build-test:watch\" \"karma start karma.conf.js\"",
"pretest:once": "npm run build-test",
"test:once": "karma start karma.conf.js --single-run",
"test:once": "karma start karma.conf.js --single-run --no-auto-watch",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary

Without this change `npm test` fires up Karma but does nothing further with it.
Copy link
Member

@CaerusKaru CaerusKaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaerusKaru CaerusKaru merged commit 9d1030b into angular:master Feb 14, 2018
@mgol mgol deleted the karma branch February 15, 2018 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants