Adding docker + protractor docs to cookbook. #9

jags14385 · 2016-09-15T20:13:53Z

Documentation.

jags14385 · 2016-09-15T20:16:04Z

@cnishina Resubmitted it with cla.

cnishina

See comments. This should have a package.json that downloads protractor as a dependency.

cnishina · 2016-09-15T20:46:44Z

protractor-docker/docker.md

+-----------------------------------------------------------------------------
+``` shell
+docker run -d --link selenium-hub:hub selenium/node-chrome:latest
+docker run -d --link selenium-hub:hub selenium/node-firefox:latest


If this example is just showing the latest node-chrome, let's take out the node-firefox

Removed it.

cnishina · 2016-09-15T20:50:16Z

protractor-docker/docker.md

+
+Install [RealVNC](https://www.realvnc.com) viewer.
+
+One can add a chrome-debug-node which has a vnc server set up to the selenium grid and see the tests running .


Discuss that in the debug, you should not use node-chrome and should use node-chrome-debug instead to use VNC Viewer when starting up your selenium grid

Also, this is noted as chrome-debug-node which should be changed to node-chrome-debug

cnishina · 2016-09-15T20:53:16Z

protractor-docker/docker.md

+docker-compose up -d --remove-orphans
+docker-compose scale chromenode=5
+
+./node_modules/.bin/protractor docker-protractor-grid-conf.js


This should have a package.json to download protractor. In your package.json, run this script as:

"scripts": { "pretest": "./run-tests.sh", "test": "protractor docker-protractor-grid-conf.js" }

Then the user can just run npm test. Also, maybe we should rename the "run-tests.sh" to "docker-setup.sh"

Added it as part of the "test" script in the package.json

cnishina · 2016-09-15T20:54:03Z

protractor-docker/docker.md

+```
+
+``` shell
+chmod +x run-tests.sh


You could chmod +x the file and add the permissions to the pull request then the user will not need to make it executable.

gave it +x permissions.

cnishina · 2016-09-15T20:54:32Z

protractor-docker/run-tests.sh

@@ -0,0 +1,12 @@
+docker -v


Let's rename the file to "docker-setup.sh" and give it "chmod +x" permissions. See comments above.

True. Renamed it.

cnishina · 2016-09-15T20:54:56Z

protractor-docker/run-tests.sh

+docker-compose up -d --remove-orphans
+docker-compose scale chromenode=5
+
+./node_modules/.bin/protractor docker-selenium-grid-conf.js


Remove this and add it to package.json as part of the test script.

Referenced the above as a shell script file and "npm install" as part of the "pretest" script.
Would still keep it in the .md file so that the reader knows what to do.

@cnishina What do you think ?

jags14385 · 2016-09-15T22:23:31Z

@cnishina Done with the code changes. Let me know , if this looks good .

cnishina · 2016-09-15T22:31:46Z

protractor-docker/package.json

+    "name": "protractor-docker-setup",
+    "dependencies": {
+        "protractor": "4.0.8",
+        "chromedriver": "2.24.1"


Chromedriver is not required if we are using docker.

cnishina · 2016-09-15T22:33:27Z

protractor-docker/docker-selenium-grid-conf.js

@@ -0,0 +1,19 @@
+exports.config = {
+	framework: 'jasmine2'
+	, specs: ['specs/*.js']


Could we have a spec file that does a really simple test? It could just make a request for angularjs.org and check to see if the title matches.

cnishina · 2016-09-15T22:34:00Z

protractor-docker/docker-selenium-grid-conf.js

+	,  capabilities: {
+		browserName: 'chrome'
+		, shardTestFiles: true
+		, maxInstances: 5


I think we should remove shardTestFiles and maxInstances. These are not necessarily docker specific. However, in you feel like it is, you should add a comment about why these values are set.

Did not think about it, will have to run the tests too check it out .

@cnishina We need so that we can run the 5 spec files in parallel at the same time. Without all the tests run on one single node. Checked it. Will mention it.

cnishina · 2016-09-15T22:35:12Z

protractor-docker/docker.md

@@ -0,0 +1,147 @@
+Running Protractor Tests on  Docker


This file is really awesome and should be available to read when the user navigates to this folder on github. This should be changed to README.md.

cnishina · 2016-09-15T22:52:00Z

protractor-docker/docker-selenium-grid-conf.js

+	, getPageTimeout: 180000
+	, allScriptsTimeout: 180000
+	, onPrepare: function () {
+		browser.manage().window().maximize();


Add comment about why onPrepare we need to maximize the window. This could be necessary if a user is running debug and wants to view the website... also add a comment about implicitylyWait.

jags14385 · 2016-09-16T00:45:09Z

@cnishina Added with the changes asked. Thanks for being patient.

cnishina · 2016-09-16T01:23:29Z

This is a great addition. Thank you for the PR!

Adding docker + protractor docs to cookbook.

cd92001

googlebot added the cla: yes label Sep 15, 2016

cnishina reviewed Sep 15, 2016

View reviewed changes

jags14385 added 3 commits September 16, 2016 08:04

Added changes according to code review.

fecbc08

Removing npm install from the shell file.

1451ed2

Discussing a bit more on how to debug tests.

40dc29f

cnishina reviewed Sep 15, 2016

View reviewed changes

cnishina added the pr: needs author response label Sep 15, 2016

Jagannath Vaikuntham added 3 commits September 16, 2016 10:11

Renamed the file and added documentation around OnPrepare settings.

03b05e9

Remving chrome driver from the package.json

a68bb89

Added the spec files.

d594b63

cnishina added pr: LGTM and removed pr: needs author response labels Sep 16, 2016

cnishina merged commit def183a into angular:master Sep 16, 2016


		Install [RealVNC](https://www.realvnc.com) viewer.

		One can add a chrome-debug-node which has a vnc server set up to the selenium grid and see the tests running .

Adding docker + protractor docs to cookbook. #9

Adding docker + protractor docs to cookbook. #9

Uh oh!

Conversation

jags14385 commented Sep 15, 2016

Uh oh!

jags14385 commented Sep 15, 2016

Uh oh!

cnishina left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jags14385 commented Sep 15, 2016

Uh oh!

cnishina Sep 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cnishina Sep 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cnishina Sep 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cnishina Sep 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jags14385 commented Sep 16, 2016

Uh oh!

cnishina commented Sep 16, 2016

Uh oh!

Uh oh!

cnishina Sep 15, 2016 •

edited

Loading

cnishina Sep 15, 2016 •

edited

Loading

cnishina Sep 15, 2016 •

edited

Loading

cnishina Sep 15, 2016 •

edited

Loading