element.all(locator).each(eachFunction) should return a promise

[jlin412]

Currently, it is difficult to use .each method for cucumber framework because there is no promise returned so we can't end and call next callback in the last protractor call like other protractor calls.
I think that we should get a fulfilled or rejected response from .each method as feature request.

This is what I like to see:

  this.Then(/^I should be able to click on each of the navigation menu item$/, function (next) {
    element.all(by.css('ul.menu li')).each(function (item) {
      item.click();
    }).then(next);
  }

Currently, I have to do:

  this.Then(/^I should be able to click on each of the navigation menu item$/, function (next) {
     var index = 0;
    element.all(by.css('ul.menu li')).count().then(function(total) {
      element.all(by.css('ul.menu li')).each(function (item) {
        index++;
        if(total === index) {
          item.click().then(next);
        }else 
          item.click();
        }
      });
    }
  }

[hankduan]

So you want the then(next) to act on only the last item? Even if then returns a promise, it would be confusing for it to return a promise of the last element. Why can't you just do this?

var menus = element.all(by.css('ul.menu li'));
menus.each(function (item) { 
  item.click();
});
menus.last().then(next); // or preferably next.call(null, menus.last())

[jlin412]

Can you do that? .last() does not return a promise.

On Tue, Sep 16, 2014 at 1:26 PM, Hank Duan notifications@github.com wrote:

So you want the then(next) to act on only the last item? Even if then
returns a promise, it would be confusing for it to return a promise of the
last element. Why can't you just do this?

var menus = element.all(by.css('ul.menu li'));
menus.each(function (item) {
item.click();
});
menus.last().then(next); // or preferably next.call(null, menus.last())

—
Reply to this email directly or view it on GitHub
#1330 (comment).

[hankduan]

Last returns an ElementFinder, which inherits Promise.

[jlin412]

It didn't work for me. Probably I am still using 0.23.1 so I use .count() instead for the same idea.
Both approaches throws errors as your mention.
menus.count().then(next); // or preferably next.call(null, menus.count());
Here is my working version:

    $$('ul.menu li').each(function (item) {
      item.getText().should.eventually.be.not.null;
    });
    browser.sleep(1000).then(next);

It is a better code pattern but I still need to call one more protractor call to end my step.
I still think that it is a good idea to return fulfilled or rejected promise for .each() and .then method.
It will work much like a Q.all block.

[hankduan]

Is there a reason you're not updating your protractor? There are significant changes since 0.23.1.

[jlin412]

I am using cucumber framework and it is blocked by
#876

I may have to fork 1.0.0 and add the workaround for this issue before I can
update which is an option right now.

On Tue, Sep 16, 2014 at 2:15 PM, Hank Duan notifications@github.com wrote:

Is there a reason you're not updating your protractor? There are
significant changes since 0.23.1.

—
Reply to this email directly or view it on GitHub
#1330 (comment).

[juliemr]

If someone wants to submit a PR to fix cucumber, I would be happy to review it!

[juliemr]

I think this is all fixed in master. I'm closing this issue since it looks like there's no unique problem here.

[jlin412]

@juliemr so .each() will return promise in updated version?