Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to the framework adapters interface to run async code before each test #3894

Closed
juliemr opened this issue Dec 29, 2016 · 0 comments

Comments

@juliemr
Copy link
Member

juliemr commented Dec 29, 2016

This will be used for things such as restarting the browser between tests. To avoid relying on control flow, we need to be able to run asynchronous things (like waiting for the new browser instance to start up).

This will look something like:

JasmineAdapter {
  addRunBeforeFunction(fn) {
    jasmine.beforeEach((done) => {
      fn().then(done);
    });
  }
}
sjelin added a commit to sjelin/protractor that referenced this issue Jan 19, 2017
sjelin added a commit to sjelin/protractor that referenced this issue Jan 19, 2017
sjelin added a commit to sjelin/protractor that referenced this issue Jan 20, 2017
sjelin added a commit to sjelin/protractor that referenced this issue Jan 20, 2017
@sjelin sjelin closed this as completed in 6c3be8c Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants