Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rewrap WebDriver promise into q promise in DriverProvider.prototype.quitDriver #3902

Closed
sjelin opened this issue Dec 30, 2016 · 0 comments
Closed

Don't rewrap WebDriver promise into q promise in DriverProvider.prototype.quitDriver #3902

sjelin opened this issue Dec 30, 2016 · 0 comments
Labels
difficulty: easy hotlist: polish status: pr pending type: cleanup
Projects
Support ControlFlow-less Selenium

Comments

@sjelin
Copy link
Contributor

sjelin commented Dec 30, 2016

Necessary for #3899 so that we return a WebDriver promise and don't mix promise types.

We did this because quitDriver's promise gets passed to teardownEnv and shutdown_, each of which use q promises. But we'll just have to move the rewrapping one level up I guess.
@sjelin sjelin mentioned this issue Dec 30, 2016
Closed
sjelin added a commit to sjelin/protractor that referenced this issue Jan 20, 2017
@sjelin
chore(quitDriver): have quitDriver return a webdriver promise directly
a3d3948 
Wrapping it in a `q` promise is blocking angular#3899

Closes angular#3902

Custom frameworks might not make this change but it'll be fine.  It'll only be a
problem in edge cases and they probably weren't returning the right promise
before anyway.
@sjelin sjelin mentioned this issue Jan 20, 2017
Merged
sjelin added a commit that referenced this issue Jan 20, 2017
@sjelin
chore(quitDriver): have quitDriver return a webdriver promise directly (
132fb86 
#3992)

Wrapping it in a `q` promise is blocking #3899

Closes #3902

Custom frameworks might not make this change but it'll be fine.  It'll only be a
problem in edge cases and they probably weren't returning the right promise
before anyway.
sjelin added a commit that referenced this issue Jan 23, 2017
@sjelin
chore(quitDriver): have quitDriver return a webdriver promise directly (
f4cf277 
#3992)

Wrapping it in a `q` promise is blocking #3899

Closes #3902

Custom frameworks might not make this change but it'll be fine.  It'll only be a
problem in edge cases and they probably weren't returning the right promise
before anyway.
sjelin added a commit that referenced this issue Jan 26, 2017
@sjelin
chore(quitDriver): have quitDriver return a webdriver promise directly (
60d9114 
#3992)

Wrapping it in a `q` promise is blocking #3899

Closes #3902

Custom frameworks might not make this change but it'll be fine.  It'll only be a
problem in edge cases and they probably weren't returning the right promise
before anyway.
@sjelin sjelin closed this as completed in 46c8898 Jan 27, 2017
igniteram pushed a commit to igniteram/protractor that referenced this issue Feb 21, 2017
@sjelin @igniteram
chore(quitDriver): have quitDriver return a webdriver promise directly (
c80f0dd 
angular#3992)

Wrapping it in a `q` promise is blocking angular#3899

Closes angular#3902

Custom frameworks might not make this change but it'll be fine.  It'll only be a
problem in edge cases and they probably weren't returning the right promise
before anyway.
bodyduardU pushed a commit to bodyduardU/protractor that referenced this issue Dec 5, 2022
@sjelin
chore(quitDriver): have quitDriver return a webdriver promise directl…
e45eac3 
…y (#3992)

Wrapping it in a `q` promise is blocking angular/protractor#3899

Closes angular/protractor#3902

Custom frameworks might not make this change but it'll be fine.  It'll only be a
problem in edge cases and they probably weren't returning the right promise
before anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy hotlist: polish status: pr pending type: cleanup
Projects
Support ControlFlow-less Selenium
Stage 0: Prep (issues)
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjelin