This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(deps): Update Travis Selenium 3.0 and latest browsers #3826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
reviewed
Dec 14, 2016
| 'version': '47', | ||
| 'selenium-version': '2.53.1' | ||
| 'version': '50', | ||
| 'selenium-version': '3.0.1' |
There was a problem hiding this comment.
I'm assuming this is the selenium standalone server version. If we upgrade to selenium standalone server 3.0.x, Firefox 47 tests will not work. Can we get our test to work with FF 48+?
Also, since this would test sauce labs, the most that they support for selenium standalone server 2.53.1 and FF 47. See https://wiki.saucelabs.com/display/DOCS/Test+Configuration+Options
If this does work on saucelabs with selenium standalone server 3.0.x and FF 50, I'll need to see how this work locally.
| @@ -465,7 +465,7 @@ describe('ElementArrayFinder', function() { | |||
| ]); | |||
| }); | |||
|
|
|||
| fit('should map and resolve multiple promises', function() { | |||
| it('should map and resolve multiple promises', function() { | |||
There was a problem hiding this comment.
This looks like something i did. Thanks for fixing this.
heathkit
force-pushed
the
update-travis
branch
from
7995417 to
80acee2
Compare
cnishina
approved these changes
Dec 15, 2016
This also drops support for Safari 9, which doesn't use safaridriver.
heathkit
force-pushed
the
update-travis
branch
from
ab368e2 to
1306a50
Compare
heathkit
added a commit
to heathkit/protractor
that referenced
this pull request
Dec 19, 2016
juliemr
pushed a commit
that referenced
this pull request
Dec 19, 2016
juliemr
pushed a commit
that referenced
this pull request
Dec 20, 2016
juliemr
pushed a commit
that referenced
this pull request
Dec 21, 2016
juliemr
pushed a commit
that referenced
this pull request
Dec 22, 2016
juliemr
pushed a commit
that referenced
this pull request
Dec 28, 2016
sjelin
pushed a commit
that referenced
this pull request
Dec 28, 2016
juliemr
pushed a commit
that referenced
this pull request
Dec 29, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also drops support for Safari 9, which doesn't use safaridriver.