Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jasmine): prevent random execution order in jasmine 3 #5126

Merged
merged 1 commit into from Jan 25, 2019

Conversation

cnishina
Copy link
Member

No description provided.

Copy link

@macroking macroking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
There is an open PR addressing the same issue.
#4842

@cnishina
Copy link
Member Author

Looking at the previous PR, it does look good (I did not see it). I am moving forward with the selenium4 branch and not doing work on the master branch.

lib/frameworks/jasmine.js Show resolved Hide resolved
@cnishina cnishina merged commit 84cdc50 into angular:selenium4 Jan 25, 2019
cnishina added a commit to cnishina/protractor that referenced this pull request Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants