Test Runner Refactor + Simultaneous Test Run Support - supported by all "run types" (hosted, sauce, etc) - part 2 #514
Conversation
…yle), refactoring launch/runner init system, and abstracting out configParser module adding in output handling for multiple browser instances and cleanup on formatting a bit refactoring to a more compositional style more refactoring, some documentation corrections, and merging in the cucumber testing framework into the new structure. Needs a bit of work still on abstracting further. updating styling/docs + a couple of bug fixes some abstraction into configParser + added header to child output reporting adding dependency q and removing some debug code feat(runner/launcher): Adding simultaneous runner capability (grid-style), refactoring launch/runner init system, and abstracting out configParser module adding in output handling for multiple browser instances and cleanup on formatting a bit refactoring to a more compositional style more refactoring, some documentation corrections, and merging in the cucumber testing framework into the new structure. Needs a bit of work still on abstracting further. updating styling/docs + a couple of bug fixes some abstraction into configParser + added header to child output reporting making some fixes to chromeOnly and sauceLabs runs fixing accidental change to conf in debugging
|
Thanks! This is looking really good. I think I'd like to merge and then I'll make a follow-up commit to fix a few style nitpicks which are not worth making you do another iteration :) I'd also like to think a little bit more about the config parser, which I think could be simpler... but that can also be a follow-up commit from me. Sound OK? |
|
You're my hero!!! and I can't believe this has been finished a couple of minutes ago! :D I'm so happy 👍 |
|
Hey Julie, Sounds great. I'll monitor the changes you make so I can understand the style preferences a bit better for future commits. Also, I feel like there's still some good re-factoring that could be of benefit with this new code, so I may hit you up with those proposed changes in the future and see if you're interested in those changes before I start work if that's OK with you. Thanks again for all the help with getting this commit in. Diego, I'm glad it helped :) |
|
Any idea when this will be released? This is going to help us out immensely. Thanks for doing all the work on it :) |
|
+1 |
|
Working on some small refactoring and adding a couple tests now - this is a pretty big change, so I want to make sure it doesn't break anything! That probably means we're looking at next weekish for release. |
|
Also very excited about this! Awesome work. |
|
Thanks Julie! It's a bunch of code and super high risk and I appreciate all your help with it. Sorry to dump so much on your plate haha. Let me know if there's something I can help with! |
|
OK! Merged as 77393d0. I did some style cleanup and refactoring in 6848180 - this was mostly to add tests and make sure the q promises work smoothly. I also added some documentation and a config using this in b568167. One slightly major change I made was to remove the configMap - I felt like it obfuscated things more than the value it added, but feel free to disagree! I'm going to make sure this is happy on Travis, and then probably release sometime next week. Thanks again! People have been asking for this for a while :) |
|
Thanks Julie! We both did a bunch of work but I feel like we made a nice improvement to the runner/config system after looking at the end result before->after. I agree the configMap obfuscated things a bit. The reason I gained an interest in making it stemmed from me running across some code and old issues that made me think having an abstraction/translation layer between the config values passed in and the internally used config might be useful for future-proofing changes to config formats, while still supporting backwards compatibility, etc. In all, I'm not too opinioned on it being there or not, so no complaints from me :) Thanks for all the feedback throughout, I learned alot. I'll try to contribute more in the future - hopefully in smaller chunks haha. |
|
Thank you both!!! |
This is a continuation of #492