This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
chore: update to @types #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
force-pushed
the
ts2.0
branch
2 times, most recently
from
785bdcf
to
71b98cd
Compare
filipesilva
added a commit
that referenced
this pull request
Sep 14, 2016
This PR updates TypeScript from 1.8.10 to 2.0.2. It does not replace `typings` with `@types`, that will happen in #157.
Merged
filipesilva
added a commit
that referenced
this pull request
Sep 14, 2016
This PR updates TypeScript from 1.8.10 to 2.0.2. It does not replace `typings` with `@types`, that will happen in #157.
filipesilva
added a commit
that referenced
this pull request
Sep 14, 2016
This PR updates TypeScript from 1.8.10 to 2.0.2. It does not replace `typings` with `@types`, that will happen in #157.
wardbell
pushed a commit
that referenced
this pull request
Sep 14, 2016
This PR updates TypeScript from 1.8.10 to 2.0.2. It does not replace `typings` with `@types`, that will happen in #157.
filipesilva
changed the title
filipesilva
force-pushed
the
ts2.0
branch
2 times, most recently
from
11297a9
to
798a833
Compare
filipesilva
force-pushed
the
ts2.0
branch
3 times, most recently
from
eb0d2d6
to
14b8ddd
Compare
andriybuday
reviewed
Oct 6, 2016
| "@types/core-js": "^0.9.34", | ||
| "@types/jasmine": "^2.5.35", | ||
| "@types/node": "^6.0.45", | ||
| "@types/protractor": "^1.5.20" |
There was a problem hiding this comment.
Compilation didn't work until after I added this: "@types/selenium-webdriver": "2.44.26"
I verified twice. Also it looks like latest version of "@types/selenium-webdriver" isn't working either.
There was a problem hiding this comment.
Good catch, thanks!
filipesilva
force-pushed
the
ts2.0
branch
2 times, most recently
from
b51baab
to
a046ef7
Compare
jkonert
pushed a commit
to jkonert/ng2-tutorial-de
that referenced
this pull request
Mar 17, 2017
This PR updates TypeScript from 1.8.10 to 2.0.2. It does not replace `typings` with `@types`, that will happen in angular/quickstart#157.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the quickstart to use the
@types/*repos. Additionally, it also updates to protractor4 to make use of it's own typings./cc @wardbell @Foxandxss