-
Notifications
You must be signed in to change notification settings - Fork 3.1k
clean up npm scripts tasks with npm-run-all #54
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it. |
CLAs look good, thanks! |
What is the advantage? I already know Thanks for the suggestion. I'll get to it when I have time. |
Hi the advantage is just that the npm scripts tasks stay readable and manageable over time as the amount of tasks grow. That is all 😄 I have been using it for a while in multiple projects and love how it cleans up the tasks. |
Aaargh! Accidentally merged. I'm reverting. Sorry. |
haha I was wondering what was going on. all good. |
I created new PR #56 that revives your changes. Now I have to fix the other stuff I broke. Nightmare! Anyone. Will look again later. |
👍 alrighty sorry to hear that you broke stuff. hope the fix will go fast! |
Hi this is just a suggestion.
It does not change behavior of the npm scripts tasks but it uses
npm-run-all
instead of concurrently to run tasks in sequence or in parallel. It makes the scripts just nicer to read.Also I made the task names more consistent by using colon in task names instead of a dash.