Cannot read property 'toJSON' of undefined

[jrgleason]

I have a project here that uses ngc. However, when I compile the project using TS 2.2.2 and the command ./node_modules/.bin/ngc -p src/lib/tsconfig.json I get the following error...

TypeError: Cannot read property 'toJSON' of undefined
    at Object.sourceMapGeneratorToConsumer (.../node_modules/tsickle/build/src/source_map_utils.js:65:42)
    at TsickleCompilerHost.combineSourceMaps (.../flex-layout/node_modules/tsickle/build/src/tsickle_compiler_host.js:167:74)
    at TsickleCompilerHost.writeFile (.../flex-layout/node_modules/tsickle/build/src/tsickle_compiler_host.js:111:28)
    at Object.writeFile (.../flex-layout/node_modules/typescript/lib/typescript.js:64240:132)
    at Object.writeFile (.../flex-layout/node_modules/typescript/lib/typescript.js:9020:14)
    at printSourceFileOrBundle (.../flex-layout/node_modules/typescript/lib/typescript.js:61197:20)
    at emitSourceFileOrBundle (.../flex-layout/node_modules/typescript/lib/typescript.js:61155:21)
    at Object.forEachEmittedFile (.../flex-layout/node_modules/typescript/lib/typescript.js:8986:17)
    at Object.emitFiles (.../flex-layout/node_modules/typescript/lib/typescript.js:61137:12)
    at emitWorker (.../flex-layout/node_modules/typescript/lib/typescript.js:64294:33)

I would expect that this is probably related to using TS 2.2

#447

[jrgleason]

I tried downgrading to 2.1.5 per the latest angular and now I get...

TypeError: Cannot read property 'file' of undefined
    at SourceMapGenerator_applySourceMap [as applySourceMap] (.../flex-layout/node_modules/source-map/lib/source-map-generator.js:176:29)
    at TsickleCompilerHost.combineSourceMaps (.../flex-layout/node_modules/tsickle/build/src/tsickle_compiler_host.js:168:39)
    at TsickleCompilerHost.writeFile (.../flex-layout/node_modules/tsickle/build/src/tsickle_compiler_host.js:111:28)
    at Object.writeFile (.../flex-layout/node_modules/typescript/lib/typescript.js:64240:132)
    at Object.writeFile (.../flex-layout/node_modules/typescript/lib/typescript.js:9020:14)
    at printSourceFileOrBundle (.../flex-layout/node_modules/typescript/lib/typescript.js:61197:20)
    at emitSourceFileOrBundle (.../flex-layout/node_modules/typescript/lib/typescript.js:61155:21)
    at Object.forEachEmittedFile (.../flex-layout/node_modules/typescript/lib/typescript.js:8986:17)
    at Object.emitFiles (.../flex-layout/node_modules/typescript/lib/typescript.js:61137:12)
    at emitWorker (.../flex-layout/node_modules/typescript/lib/typescript.js:64294:33)

[jrgleason]

I could fix the second issue by removing this if (which looks right given the TODO)...

tsickle_compiler_host.js

:169

if (false) {// this.decoratorDownlevelSourceMaps.size > 0) {
            // TODO(lucassloan): remove when the .d.ts has the correct types
            for (var _b = 0, _c = tscSourceMapConsumer.sources; _b < _c.length; _b++) {
                var sourceFileName = _c[_b];
                var sourceMapKey = this.getSourceMapKeyForPathAndName(filePath, sourceFileName);
                var decoratorDownlevelSourceMapGenerator = this.decoratorDownlevelSourceMaps.get(sourceMapKey);
                var decoratorDownlevelSourceMapConsumer = sourceMapUtils.sourceMapGeneratorToConsumer(decoratorDownlevelSourceMapGenerator, sourceFileName, sourceFileName);
                tscSourceMapGenerator.applySourceMap(decoratorDownlevelSourceMapConsumer);
            }
        }

[jrgleason]

Any word on this? I can issue a pull request if others think this is ok

[ThomasBurleson]

@hansl - any thoughts ?

[hansl]

Not sure why me, Lucas is the better reference for this.

It seems to be in their source map generation where a source map hasn't been created. Do you have source maps for that file?

[mprobst]

/CC @LucasSloan

[ThomasBurleson]

@LucasSloan - here is a link to the latest @angular/flex-layout builds with sourcemaps.

Here is the link to the originating issue and PR:

• PR - update(build): update to Angular 4 dependencies. flex-layout#238
• Issue - angular4 aot compilation flex-layout#236

[LucasSloan]

@jrgleason Removing that if block isn't the right solution, that comment refers to a type annotation not present in the compiled js code. I'll take a look.

[LucasSloan]

@jrgleason @ThomasBurleson It looks like the issue is that you specify a maproot of "" in your tsconfig. Can you remove that setting?

[ThomasBurleson]

Fyi @devversion

…

On Mon, Apr 3, 2017, 5:52 PM Lucas Sloan ***@***.***> wrote: @jrgleason <https://github.com/jrgleason> @ThomasBurleson <https://github.com/ThomasBurleson> It looks like the issue is that you specify a maproot of "" in your tsconfig. Can you remove that setting? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#453 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAM17YZjQBQrqjRgP3O3TVWCA7tsKyvcks5rsYZPgaJpZM4MqyZ8> .

[jrgleason]

@LucasSloan this is my tsconfig I don't see maproot...

{
"compilerOptions": {
"target": "es5",
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"sourceMap": true,
"jsx": "react",
"noImplicitAny": false,
"suppressImplicitAnyIndexErrors": true,
"lib": [
"es2016",
"dom"
]
},
"include": [
"src//*"
],
"exclude": [
"node_modules",
"/*.spec.ts"
]
}

[LucasSloan]

@jrgleason The tsconfig in your original comment src/lib/tsconfig.json has one:

{
"compilerOptions": {
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"declaration": true,
"inlineSources": true,
"skipDefaultLibCheck": true,
"noImplicitAny": false,
"noImplicitReturns": true,
"suppressImplicitAnyIndexErrors": true,
"stripInternal": false,
"mapRoot": "",
"rootDir": ".",
"sourceMap": true,
"target": "es5",
"module": "es2015",
"moduleResolution": "node",
"lib": ["es6", "es2015", "dom"],
"outDir": "../../dist/@angular/flex-layout",
"typeRoots": [
"../../node_modules/@types"
]
},
"exclude": [
"**/.spec.",
"utils/testing/custom-matchers.ts",
"utils/testing/helpers.ts",
"system-config-spec.ts",
"tsconfig-demo-app."
],
"angularCompilerOptions": {
"genDir": "../../dist/aot/@angular/flex-layout",
"debug": true
}
}

[gonzofish]

@LucasSloan that suggestion worked for my case--thanks a lot!