This repository was archived by the owner on May 22, 2025. It is now read-only.
fix import error when running tsickle on valid tsc code #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evmar
reviewed
Oct 5, 2016
| ...program.getOptionsDiagnostics(), | ||
| ...program.getSyntacticDiagnostics(), | ||
| ...program.getGlobalDiagnostics(), | ||
| ]; | ||
| if (diagnostics.length > 0) { |
There was a problem hiding this comment.
Rather than this, we should delete this diagnostics check entirely -- we don't care about any errors that are produced here.
There was a problem hiding this comment.
Just this one? Should the other calls to allDianostics.push in toClosureJS be preserved?
There was a problem hiding this comment.
Just this one, your new change looks right.
|
Can you change the description to: tsickle's current approach is to run TypeScript, modify the output, and pass it through TypeScript again. We don't want to type check the code twice, so only check it on the first pass. Fixes #189. |
tsickle's current approach is to run TypeScript, modify the output, and pass it through TypeScript again. We don't want to type check the code twice, so only check it on the first pass. Fixes #189.
|
Done. |
evmar
approved these changes
Oct 5, 2016
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsickle's current approach is to run TypeScript, modify the output, and pass it through TypeScript again. This can cause TypeScript to think imports have been declared twice (and fail accordingly).
As @evmar discovered with the internal build of tsickle (b/30708240), this can be worked around by ensuring
getDeclarationDiagnosticsisn't called on the second pass. A more permanent solution would eliminate the second pass entirely, solving #189.