styles.css not included inline in server render

[arutnik]

I'm submitting a ...

- [ ] bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
- [ x] feature request
- [ ] Support request => Please do not submit support request here, instead see https://github.com/angular/universal/blob/master/CONTRIBUTING.md#question

What modules are related to this Issue?

- [ ] aspnetcore-engine
- [ ] common
- [ x] express-engine
- [ ] hapi-engine
- [ ] module-map-ngfactory-loader

Current behavior?

The CSS declared in styles.css is included in the client bundle, but it is not inlined into the server bundle the way component styles are.

Expected behavior?

Any CSS in the styles.css should be (optionally?) inlined in the server rendered html and transitioned out when the client loads, the way other component CSS does.

Minimal reproduction with instructions

1. Clone this repo
2. Add any CSS to styles.css that should apply anywhere. Eg. body { color: pink; }
3. Open any server rendered route and view the html that is generated
4. Note that the CSS rule you added does not appear inlined in the HTML, it only appears once the client bundle is loaded.

Environment:

@nguniversal versions

• aspnetcore-engine:
• common:
• express-engine:
• hapi-engine:
• module-map-ngfactory-loader:

<!--
Output from: `ng --version`.
If nothing, output from: `node --version` and `npm --version`.
  Windows (7/8/10). Linux (incl. distribution). macOS (El Capitan? Sierra?)
-->

Other information (optional)

My application has a lot of base styles defined in styles.css and it looks really bad before the transition to the client application when these styles are not available in the server view.

[twoheaded]

The same issue. My global style.scss and Material theme.scss included in the angular.json in build.styles section. And this styles are not applied while polyfills.js is loading

[Priemar]

Hey,

i had the same problem. Im actually using the following workaround to include the "main" styles. Its not a perfect solution but until there is a fix / extension in angular cli it does the job.

1. i created a new component which i added to the server.module

@Component({ selector: 'app-ssr', template: '', //we need to use an extra scss where the style.scss is imported, otherwise there is a webpack(replace) webpack error styleUrls: ['app.server.component.scss'], //this scss only imports the "main" style.scss encapsulation: ViewEncapsulation.None }) export class AppServerComponent {}

The ServerModule, (im bootstrap.. this component in the server module (only in the server module, dont use this new component in the client module, bec. the styles will be included in the generated file which would increase the bundle size. But for the server bundle its ok bec its never transfered to the client)

@NgModule({ imports: [ ... <your imports>... ], declarations: [ AppServerComponent ], bootstrap: [AppComponent, AppServerComponent], }) export class AppServerModule {}

add the component 'tag' (app-ssr) into the index.html -> so it can be bootstrapped

The only downside of this approach is you always have the item in your html. no matter if its SSR or not. In my case this tag doesnt matter, and you can remove it when app component is loaded and not SSR.

In my case im fine with this tag for the workaround.

Hope it helped someone else.

But im looking forward for a real / supported solution, to remove this workaround. So let me know if someone found a better solution.

[Gorniv]

@Priemar is it right workaround ?

[marcinkunert]

@Gorniv yes it is, I'm currently using this without major issues

[Priemar]

@Gorniv yes it is, i'm also using my workaround in different applications without any issues, maybe there is already a fix/other solution available ?!?!
I didn't do any research since i posted the workaround.

[Gorniv]

I use InlineStyleComponent at app.browser.module.ts and app.server.module.ts because it is work better.
If I only remove CSS from angular.json(browser+server) and use the only app.server.module I have a good view from the server and when angular loaded CSS not working.
this solution load style.css adn ignore inline style from server.

[fluidsonic]

I ran into the same issue but found a different workaround.

Forcing Angular to extract the global styles into their own files and loading them using <link rel="stylesheet"> correctly loads them in both cases, with and without SSR.

Set extractCss to true in build/options in angular.json.

Is there any documentation for extractCss?

[peturh]

@fluidsonic Exactly how to you "Force Angular to extract the global styles into their own files"?

[fluidsonic]

@peturh nothing more than setting extractCss to true. Doesn't that work for you?

[Hobart2967]

A better approach, solving that you have to have an all-time call to the app-ssr component. One downside is still in: The app-ssr component still get's bundled. But anyhow, it's not called at anytime in browser:

Create two classes BrowserAppComponent and ServerAppComponent, both deriving from AppComponent. Copy the Component annotation from AppComponent and paste it as the Component annotation for BrowserAppComponent AND ServerComponent.

import { ViewEncapsulation, Component } from '@angular/core';
import { AppComponent } from './app.component';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.scss'],
  encapsulation: ViewEncapsulation.None
})
export class BrowserAppComponent extends AppComponent { // Derive from AppComponent
}

import { ViewEncapsulation, Component } from '@angular/core';
import { AppComponent } from './app.component';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.scss'],
  encapsulation: ViewEncapsulation.None
})
export class ServerAppComponent extends AppComponent { // Derive from AppComponent
} 

Remove the Component annotation from AppComponent Mark it as abstract for architectural reason.

export abstract class AppComponent { 
  // .... APP LOGIC HERE ...   
}

Now, last but not least, add server-app.component.scss to the styleUrls array of ServerAppComponent, like @Priemar did.

import { ViewEncapsulation, Component } from '@angular/core';
import { AppComponent } from './app.component';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.scss', './server-app.component.scss'],
  encapsulation: ViewEncapsulation.None
})
export class ServerAppComponent extends AppComponent { // Derive from AppComponent
} 

And define the SCSS:

@import "../../../styles.scss";

Cheers 🍻 Hint: For sure, the app module needs to export components and directives originally used in AppComponent's template.

Hey,

i had the same problem. Im actually using the following workaround to include the "main" styles. Its not a perfect solution but until there is a fix / extension in angular cli it does the job.

1. i created a new component which i added to the server.module

@Component({ selector: 'app-ssr', template: '', //we need to use an extra scss where the style.scss is imported, otherwise there is a webpack(replace) webpack error styleUrls: ['app.server.component.scss'], //this scss only imports the "main" style.scss encapsulation: ViewEncapsulation.None }) export class AppServerComponent {}

The ServerModule, (im bootstrap.. this component in the server module (only in the server module, dont use this new component in the client module, bec. the styles will be included in the generated file which would increase the bundle size. But for the server bundle its ok bec its never transfered to the client)

@NgModule({ imports: [ ... <your imports>... ], declarations: [ AppServerComponent ], bootstrap: [AppComponent, AppServerComponent], }) export class AppServerModule {}

add the component 'tag' (app-ssr) into the index.html -> so it can be bootstrapped

The only downside of this approach is you always have the item in your html. no matter if its SSR or not. In my case this tag doesnt matter, and you can remove it when app component is loaded and not SSR.

In my case im fine with this tag for the workaround.

Hope it helped someone else.

But im looking forward for a real / supported solution, to remove this workaround. So let me know if someone found a better solution.

[vikerman]

I don't understand the original report that syles.css is loaded only when the client bundle loads. In production builds styles.css should just be present as a link tag in index.html?

This should block any rendering before the server rendered HTML is displayed? Only in development build the CSS is loaded as part of the dev build by webpack so that it can be refreshed when the CSS changes.

[axelboc]

Seems that external stylesheets don't block rendering in Firefox. There's definitely a FOUC in this browser when extractCss is true. Found an open issue about it (I think): https://bugzilla.mozilla.org/show_bug.cgi?id=1459305. In SSR, Angular outputs script tags at the end of the body without async, which is one of the cases mentioned in the issue.

[vikerman]

CSS should be render blocking -

https://developers.google.com/web/fundamentals/performance/critical-rendering-path/render-blocking-css

https://developer.mozilla.org/en-US/docs/Learn/Performance/CSS_performance

The other point is whether one wants to inline the CSS for better performance. But I'm still trying to understand the original problem where CSS is downloaded as part of client bundle and causing FOUC.

[ErazerBrecht]

@vikerman
We have the exact same problem as the 'original problem'.
The problem is that the styles are not 'loaded' by the SSR application

In our case:

            "styles": [
              "node_modules/typeface-montserrat/index.css",
              "node_modules/typeface-open-sans/index.css",
              "node_modules/typeface-roboto-mono/index.css",
              "node_modules/ngx-toastr/toastr.css",
              "shared/styles.scss",
              "projects/public/src/styles.scss"
            ],

And in FF this sometimes results in a flash.
I never noticed this (I don't really use FF) and I always thought this was a limitation by Angular Universal. But when digging deeper I found out that it's indeed the global styles that aren't loaded.

I can share our production url:
https://www.intigriti.com/companies´

where you clearly see this when checking the raw html returned by SSR.
(Lot of Times New Roman, non styles navbar, ... -> All defined in our global styles)

Is there a recommend workaround?

EDIT: The workaround above works ;)
A played a bit around and now have a balanced 'index.html' (not all styling but most of it that's important on that page)

Sincerely, Brecht
And thanks in advance!