Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension): disable rename override to allow built in TS renaming #1687

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

atscott
Copy link
Collaborator

@atscott atscott commented Jun 7, 2022

This is a rollback of #1589 due to breaking rename scenarios in
projects.
#1683 (comment)

Fixes #1685

@atscott atscott added the target: patch This PR is targeted for the next patch release label Jun 7, 2022
@atscott
Copy link
Collaborator Author

atscott commented Jun 7, 2022

// cc @ivanwonder

@atscott atscott added the action: merge Ready to merge label Jun 7, 2022
This is a rollback of angular#1589 due to breaking rename scenarios in
projects.
angular#1683 (comment)

Fixes angular#1685
@atscott atscott merged commit 7233c7d into angular:main Jun 7, 2022
atscott added a commit that referenced this pull request Jun 7, 2022
…#1687)

This is a rollback of #1589 due to breaking rename scenarios in
projects.
#1683 (comment)

Fixes #1685

(cherry picked from commit 7233c7d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v14.0 breaks renaming
2 participants