refactor: ensure errors with dynamic logging are not swallowed #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures errors printed with dynamic logging are not swallowed. This is easily confusing as the report summary is currently just printed with e.g. zero completed app generations.
crisbeto
approved these changes
Sep 16, 2025
| ? ('text-only' as const) | ||
| : ('dynamic' as const), | ||
| defaultDescription: '`dynamic` (or `text-only` when `CI=1`)', | ||
| requiresArg: true, |
There was a problem hiding this comment.
If you currently use wcs eval <..> --logging without a value, it will not show help. I think requiring an argument is better here. WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures errors printed with dynamic logging are not swallowed. This is easily confusing as the report summary is currently just printed with e.g. zero completed app generations.