Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Incompatible with SignalR2.2.1 #754

@saridakis

Description

@saridakis

This block of code in 0.8.7

desc.get = function () {
// in some of windows's onproperty callback, this is undefined
// so we need to check it
var target = this;
if (!target && obj === _global$1) {
target = _global$1;
}
if (!target) {
return null;
}
var r = target[_prop] || null;
// result will be null when use inline event attribute,
// such as OK
// because the onclick function is internal raw uncompiled handler
// the onclick will be evaluated when first time event was triggered or
// the property is accessed, #525
// so we should use original native get to retrieve the handler
if (r === null) {
if (originalDesc && originalDesc.get) {
r = originalDesc.get.apply(this, arguments);
if (r) {
desc.set.apply(this, [r]);
if (typeof target['removeAttribute'] === 'function') {
target.removeAttribute(prop);
}
}
}
}
var value = target[_prop] || null;
return value && value.hasOwnProperty(VALUE) ? value[value] : value;
};
has been changed in version 0.8.8.

You have remove the if ( r === null ) block with something new. For some reason the SignalR2.2.1 version, when it comes to call that function it raises an error, something like 'Cannot read apply of undefined...'. I suppose that this is because, you have remove the if (originalDesc && originalDesc.get) line. Please check this out.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions