Change replacement token in json files from x to {x}

[tmilnthorp]

I was adding some better localization code (via resource files, at least for the prefixes at first), and noticed that if I wanted to use a const for SiPrefixes it would fail during text replacement:

public class SiPrefixes
{
    public const double Milli = 1e-3;
}

x would match the x in SiPrefixes.Milli and the conversion functions (eg GetValueInBaseUnit) would be incorrect:

case AccelerationUnit.MillistandardGravity: return (SiPrefi_valuees.Milli*9.80665) * SiPrefixes.Milli;

A more specific replacement token such as [x] or $x$ would limit scope better since we're doing a string replacement.

Open to ideas for better replacement tokens 😃

[angularsen]

I have no strong preference, but [x] looks like an array to me and $x$ is unfamiliar.

{0} and {myVariable} or {{myVariable}} are commonly used in templating.
How about {value}? Or just {x}.

[tmilnthorp]

I have no strong preference, but [x] looks like an array to me and $x$ is unfamiliar.

{0} and {myVariable} or {{myVariable}} are commonly used in templating. How about {value}? Or just {x}.

That looks good to me.

Is there any doc files I'm missing that need touched?

[codecov]

Codecov Report

Merging #1028 (fd5036f) into master (2ef6659) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1028   +/-   ##
======================================
  Coverage    82.7%   82.7%           
======================================
  Files         309     309           
  Lines       47598   47598           
======================================
  Hits        39317   39317           
  Misses       8281    8281           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef6659...fd5036f. Read the comment docs.

[angularsen]

Is there any doc files I'm missing that need touched?

Not that I know of, just search the repo for ... x 😆

[angularsen]

Release UnitsNet/4.117.0 · angularsen/UnitsNet